-
-
Notifications
You must be signed in to change notification settings - Fork 21.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend NavigationMeshSourceGeometryData[23]D
to allow data merging
#88221
Extend NavigationMeshSourceGeometryData[23]D
to allow data merging
#88221
Conversation
Imo it would be better to add a Just because you want to merge something does not mean you want to have all the overhead of the single-threaded parsing again as well. Many users create their entire source geometry procedual in scripts never using the parse function. They might still want the ability to merge two of them together which sounds useful doing in C++ compared to doing a slow copy in scripts. Also changing the parse function on the NavigationServer breaks the function signature and compatibility while adding a merge() function does not. |
72ea860
to
85fd0d7
Compare
85fd0d7
to
ed62070
Compare
NavigationServer3D
NavigationMeshSourceGeometryData[23]D
to allow data merging
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approve for the API.
Not sure about the code style, the use of ::Size looks exotic compared to the rest of the engine.
Seems like the "Size" alias is a relatively new thing since the 64-bit CowData upgrade. A quick look-up tells me it has never been used like this before. Other code just... puts the size into an Personally I would just do that, |
ed62070
to
bb7c28f
Compare
bb7c28f
to
ab24276
Compare
Thanks! |
This PR adds
merge
method toNavigationMeshSourceGeometryData3D
This PR therefore adds a way to avoid boilerplate code such as lampe-games/godot-open-rts@487e995#diff-0291eaa88b59eec77f3d1546e6404bea1391d58eec1ee646874dded17f0bfe16R60-R71